Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node id serialization optional #76

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

huchenlei
Copy link
Member

Related issue: Comfy-Org/ComfyUI_frontend#438

Some users specifically want a certain node order on serialization because the node order defines which node is displayed in front of which when 2 or more nodes overlay with each other. This PR makes sort optional and not sort by default.

@huchenlei
Copy link
Member Author

Test failure is expected:

FAIL tests-ui/tests/litegraph.test.ts
  LGraph
    ✕ should serialize deterministic node order (8 ms)

  ● LGraph › should serialize deterministic node order

@huchenlei huchenlei merged commit 1cbb74b into master Aug 18, 2024
3 of 4 checks passed
@huchenlei huchenlei deleted the serializeLGraphOption branch August 18, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant