ES2015 / ES6 class conversion #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would recommend doing this step by step. A large PR that fixes everything is not likely get merged. |
|
I'll leave it here in draft. Hopefully it is useful to someone to pick up and run with. If that's counterproductive, please feel free to close it. |
This was referenced Aug 9, 2024
This was referenced Aug 29, 2024
|
@huchenlei Happy to close this one? Pretty sure it's all done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely drafty - could blow out candles without warning. Should be 100% faithful to original intent, but at least some consumers are using foundational rewrites that may break with these changes.
Edits welcome.