Fix cloning pinned nodes

[pythongosssss]

Pin node
right click -> clone -> crash
or copy/paste -> crash

[webfiltered]

Hrm, I don't think pin itself is the issue - more that it shouldn't be getting called at all on any node that doesn't have a valid graph. Having a look.

[pythongosssss]

It's being called from LGraphNode.configure which also has the check on graph.
Nodes are configured then added to the graph, so graph wont be set at this point.

[webfiltered]

Yeah - just tested this:

    this.resizable = !this.pinned

Works perfectly.

[webfiltered]

Amusingly, the preceding comment was better than the code.

litegraph.js/src/LGraphNode.ts

Line 572 in a0b06c1

// Sync the state of this.resizable.

[pythongosssss]

If in future pin were to have some additional logic, e.g. pin to the top of the stack, would it not be better to have the logic for pin in the pin method, rather than duplicated?

[webfiltered]

It would be better to actually serialise and deserialise any additional *state, no?

[pythongosssss]

I don't think so, as if new functionality is added to pin that shouldn't rely on the state of the serialized graph

[webfiltered]

Is that a good reason to have the code work that way right now? The code should really just.. do what it's designed to do. afaik it was never designed to call pin this way - I believe pin got changed, and this call site didn't.

But I just spent 20mins trying to ensure I didn't come across as argumentative. So if you're set on this, I won't butt in further! =P