Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream Manager. #912

Merged
merged 13 commits into from
Mar 1, 2025
Merged

Use upstream Manager. #912

merged 13 commits into from
Mar 1, 2025

Conversation

robinjhuang
Copy link
Member

@robinjhuang robinjhuang commented Feb 16, 2025

  • Includes bug fixes from manager:
    ltdrdata/ComfyUI-Manager@488f023
  • Fixed: migrating custom nodes: uses restore-to to fix importing custom nodes.
  • Remove extra ComfyUI-Manager when migrating/importing from another ComfyUI install
  • Updated requirements.compiled

┆Issue is synchronized with this Notion page by Unito

@robinjhuang robinjhuang requested a review from a team as a code owner February 16, 2025 02:42
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 16, 2025
@robinjhuang robinjhuang marked this pull request as draft February 16, 2025 02:42
@robinjhuang robinjhuang changed the title Draft: Rh manager new Draft: Use upstream Manager. Feb 16, 2025
@robinjhuang robinjhuang marked this pull request as ready for review February 24, 2025 22:44
@robinjhuang robinjhuang changed the title Draft: Use upstream Manager. Use upstream Manager. Feb 24, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 24, 2025
Copy link

socket-security bot commented Feb 24, 2025

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@robinjhuang
Copy link
Member Author

Rebased and tested again. @webfiltered tests are failing because I updated the version to 0.4.22 and the screenshots don't match on the error page anymore. How do I update that?

@webfiltered
Copy link
Contributor

webfiltered commented Feb 27, 2025

Process is currently:

  1. Run tests
  2. Verify that the only things changed are what's expected
  3. Run this locally:
yarn run test:e2e:update
  1. Commit new expectations

All screenshot diffs are overwritten by playwright at once - doing a partial diff requires discarding any updated expectations before committing.

Edit: Adding this to testing README. Done.

@webfiltered
Copy link
Contributor

Or.. we could just resolve the problem at the source.

@sync-by-unito sync-by-unito bot closed this Feb 27, 2025
@robinjhuang robinjhuang reopened this Feb 28, 2025
@robinjhuang
Copy link
Member Author

@webfiltered Closed this by accident. I rebased and tested. It should fix a few issues with current manager, including migrating custom nodes. Can you PTAL when you have time?

@robinjhuang robinjhuang requested a review from webfiltered March 1, 2025 04:32
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 1, 2025
@robinjhuang robinjhuang merged commit 83a6541 into main Mar 1, 2025
7 checks passed
@robinjhuang robinjhuang deleted the rh-manager-new branch March 1, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants