-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use upstream Manager. #912
Conversation
3ec307e
to
24a7101
Compare
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
123cba3
to
7f736bb
Compare
Rebased and tested again. @webfiltered tests are failing because I updated the version to 0.4.22 and the screenshots don't match on the error page anymore. How do I update that? |
Process is currently:
yarn run test:e2e:update
All screenshot diffs are overwritten by playwright at once - doing a partial diff requires discarding any updated expectations before committing. Edit: Adding this to testing README. Done. |
Or.. we could just resolve the problem at the source. |
d5dffd8
to
c713dda
Compare
@webfiltered Closed this by accident. I rebased and tested. It should fix a few issues with current manager, including migrating custom nodes. Can you PTAL when you have time? |
Co-authored-by: filtered <[email protected]>
ltdrdata/ComfyUI-Manager@488f023
restore-to
to fix importing custom nodes.┆Issue is synchronized with this Notion page by Unito