[Refactor] useAbsolutePosition composable #2589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new composable
useAbsolutePosition
to handle absolute positioning calculations for elements on the LiteGraph canvas. The main changes involve extracting the positioning logic fromTitleEditor.vue
into a reusable composable that manages the conversion of canvas coordinates to client coordinates, handling scaling, and maintaining the position state. TheTitleEditor
component has been simplified by leveraging this new composable, replacing the manual style object initialization and coordinate calculations with cleaner, more maintainable code. The composable accepts aPositionConfig
interface for position and size, along with optional scale and extra style properties, making it more flexible for reuse across different components that need canvas-to-screen coordinate conversion.┆Issue is synchronized with this Notion page by Unito