[3d] use threejs native viewHelper #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as many feedback, the view change (font, top, etc) doesn't be accurate previously, so I switch to threejs native viewHelper - gizmo to support this feature.
also, I start to redesign the UI, for example, move the some inputs from parameter panel to threejs scene directly, this is because users are requesting new features, if we add the parameters as node inputs, the list will grow too long later, which I don't think it is good design.
BE change is here
comfyanonymous/ComfyUI#6436
here is the demo
https://github.com/user-attachments/assets/5333146f-73e3-4563-a17d-e1cd34d661c5
┆Issue is synchronized with this Notion page by Unito