This repository has been archived by the owner on Nov 13, 2018. It is now read-only.
Changing "Drop at Edge" Query String handling #641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removing drop_qstring generation altogether as it doesn't work with header rewrite
|
@smalenfant - sorry this has taken so long... Just seems there's a lot of details here that could go wrong. You use this in prod, yes? You edit the official release to get this code in? Also, do you use it in conjunction with signed urls? |
|
Thanks for the feedback... Not running in production, but was running in the lab. I'll need to run a bunch of test cases. I'll keep updating the Pull Request until it's ready. |
|
Closing this pull-request for time being. Looks like I mixed some regex_remap with header_rewrite. Still looking for a solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite ready to merge. It compiles and tested OK.