This repository has been archived by the owner on Nov 13, 2018. It is now read-only.
Always insert a 'volume=x' parameter into storage.config #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATS has an issue where it cannot figure out what volume to assign to a replacement drive if other drives already have an existing volume assignment. Explicitly setting the volume parameter for every drive in storage.config works around this issue.
| $text .= storage_dot_config_volume_text( | ||
| $data->{RAM_Drive_Prefix}, $data->{RAM_Drive_Letters}, | ||
| $data->{RAM_Volume}, $has_multiple_volumes | ||
| $data->{RAM_Volume} |
There was a problem hiding this comment.
Does this need to pass $assigned_volume?
I'm not sure that this change does anything unless you make changes to the TO Db that the UI would never make.
| ); | ||
| } | ||
|
|
||
| # Default to 2 here | ||
| $assigned_volume = 2; |
There was a problem hiding this comment.
What happens if you have a RAM_Drive_Prefix parameter in the profile but no RAM_Volume parameter, and the Disk_Volume parameter is set to 2?
There was a problem hiding this comment.
Shouldn't the UI prevend that?
There was a problem hiding this comment.
Should and does are two separate things. These particular configuration items are just parameters in the parameter table that are mapped to a profile. That means there's zero field validation happening; the wild wild west. Anything is possible; they could set RAM_Volume to X if they wanted to.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATS has an issue where it cannot figure out what volume to assign
to a replacement drive if other drives already have an existing
volume assignment. Explicitly setting the volume parameter for every
drive in storage.config works around this issue.
This is a fix for issue #1253