This repository has been archived by the owner on Nov 13, 2018. It is now read-only.
Fix TO duplicate PRE_PROD on new install #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PRE_PROD status was being added by both
dataload.goviastatus.json, and a Goose migration. Since the migration will always run on both new installs and upgrades, removing it fromdataloadseems like the right solution.I looked into letting both dataload and the migration insert it with
insert ignore(sostatus.jsoncould sort of act as documentation of the statuses), but the PK is an ID, not the name, so there's no way to do that without a nontrivial query or schema modification.Fixes #950