Fix postinstall prompting for TO user every time #1205
Conversation
| @@ -667,6 +672,7 @@ sub profiles_exist { | |||
| foreach my $profile (@$profiles_response) { | |||
| if ( !exists $initial_profiles{ $profile->{"name"} } ) { | |||
| print "Found existing profile (" . $profile->{"name"} . ")\n"; | |||
| open( my $reconfigure_defaults_file, '>>', $reconfigure_defaults ) or die("Failed to open() $reconfigure_defaults: $!"); | |||
There was a problem hiding this comment.
why create it both here and line 687? I think this one should go away...
There was a problem hiding this comment.
If this one goes away, the other one will never get called. We could remove the second open, because the profiles_exist() call will implicitly create it; but we'll still have to call profiles_exist() the second time, because the file doesn't get created on the first call. So
if ( profiles_exist() ) { open( my $reconfigure_defaults_file, '>>', $reconfigure_defaults ) or die("Failed to open() $reconfigure_defaults: $!"); }
could be changed to just profiles_exist().
There was a problem hiding this comment.
either way.. I think there should be just one..
There was a problem hiding this comment.
Ok, removed the other one.
rob05c
force-pushed
the
topostinstallnoadminreprompt
branch
from
42ed43a to
68a9dc6
Compare
Changes postinstall .reconfigure_defaults touch to overwrite instead of appending, per PR comment.
Fix postinstall prompting for TO user every time
Fixes #1204