This repository has been archived by the owner on Nov 13, 2018. It is now read-only.
Add support for providing geolocation coordinates on a coverage zone entry to improve routing accuracy #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CZ hit to occur when no matching CacheLocation exists as it now uses Geolocation to find the closest CacheLocation.
| @@ -120,11 +131,16 @@ public static NetworkNode generateTree(final JSONObject json) { | |||
| } | |||
|
|
|||
| public NetworkNode(final String str) throws NetworkNodeException { | |||
| this(str, null); | |||
| this(str, null, null); | |||
There was a problem hiding this comment.
Don't really need this change
There was a problem hiding this comment.
Technically true, however when written this way we have one less constructor to pass through to reach the one in the above change. That said, I don't feel strongly about it.
…ath and cyclomatic complexity warnings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.