This repository has been archived by the owner on Nov 13, 2018. It is now read-only.
Dockerfile fixes #1149
Merged
Dockerfile fixes #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,10 +70,13 @@ init() { | |||
| influx -execute 'create retention policy daily on deliveryservice_stats duration 26h replication 3 DEFAULT' | |||
| influx -execute 'create retention policy daily_stats on daily_stats duration INF replication 3 DEFAULT' | |||
There was a problem hiding this comment.
The retention policy on daily_stats should be "indefinite" (I probably had you looking at out-of-date docs). Also we want to create the monthly RPs for each database as well as the CQs. Checkout what this is doing: https://github.com/Comcast/traffic_control/blob/master/traffic_stats/influxdb_tools/create_ts_databases.go I have an issue open for 1.5.0 to compile create_ts_databases and put it in the TS build, at that point all we need to do it run it.
|
looks good to me, thanks @robert-butts! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Grafana and Heka to the Dockerfiles, and fixes the Traffic Vault Dockerfile to listen on 0.0.0.0.