Skip to content
This repository has been archived by the owner on Nov 13, 2018. It is now read-only.

Delivery service UI allows multiple regexes with the same order #531

Closed
elsloo opened this issue Sep 16, 2015 · 2 comments · Fixed by #1194
Closed

Delivery service UI allows multiple regexes with the same order #531

elsloo opened this issue Sep 16, 2015 · 2 comments · Fixed by #1194

Comments

@elsloo
Copy link
Contributor

elsloo commented Sep 16, 2015

The edit delivery service UI allows multiple regexes with the same value in the order field. This causes unintended consequences downstream in Traffic Monitor, for example, when two HOST regexes are specified with order = 0. Modify Traffic Ops such that this UI allows only one regex per order value.

@elsloo
Copy link
Contributor Author

elsloo commented Sep 16, 2015

The following query can be used to identify any delivery services configured with more than one regex with a given set number value:

select d.xml_id, dr.set_number, count(*) from deliveryservice d left join deliveryservice_regex dr on dr.deliveryservice = d.id join regex r on r.id = dr.regex where r.type=(select id from type where name='HOST_REGEXP') group by d.xml_id, dr.set_number having count(*) > 1;

@dewrich dewrich added the backlog label Oct 6, 2015
@mtorluemke mtorluemke added this to the 1.1.10 milestone Oct 6, 2015
elsloo added a commit to elsloo/traffic_control that referenced this issue Mar 21, 2016
@rob05c
Copy link
Member

rob05c commented Mar 22, 2016

Seems like it'd be ideal if the GUI didn't allow duplicate orders either, i.e. selected order numbers were removed via JS from other dropdowns. Or better yet, order was determined by dragging and dropping. But, not worth doing in 1.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants