Skip to content
This repository has been archived by the owner on Nov 13, 2018. It is now read-only.

Add Traffic Ops dynamic volume number calculation #1334

Closed
rob05c opened this issue Apr 20, 2016 · 0 comments · Fixed by #1348
Closed

Add Traffic Ops dynamic volume number calculation #1334

rob05c opened this issue Apr 20, 2016 · 0 comments · Fixed by #1348
Assignees
Milestone

Comments

@rob05c
Copy link
Member

rob05c commented Apr 20, 2016

Currently, Traffic Ops volume.config (and storage.config volume number) is created from parameters, Disk_Volume, RAM_Volume, and SSD_Volume.

There's no reason to calculate volume numbers from user input. They can be calculated from the Drive_Prefix parameters. For example, Drive_Prefix only gets volume 1. If Drive_Prefix and SSD_Drive_Prefix exist, Disks get volume 1 and SSDs get volume 2.

This should be a relatively small and safe change. The logic that needs changed/added is in traffic_ops/app/lib/UI/ConfigFiles.pm sub volume_dot_config and storage_dot_config (and a comment in hosting_dot_config).

Putting this in the 1.8 milestone because it isn't critically important, and it can wait for 2.0 if 2.0 is out soonish. But if it's a long time to get out, we should go ahead and do this in 1.x, because it's not big and makes one less thing to go wrong in production.

@rob05c rob05c self-assigned this Apr 20, 2016
@rob05c rob05c added this to the 1.8.0 milestone Apr 20, 2016
rob05c added a commit to rob05c/traffic_control that referenced this issue Apr 25, 2016
Changes Traffic Ops to calculate volume numbers from *Drive_Prefix
parameters, instead of using separate Volume parameters.

Resolves Comcast#1334
@rob05c rob05c modified the milestones: 1.6.0, 1.8.0 Apr 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant