Merge pull request #1605 from elsloo/1.6.x_backport_fix_broken_ds_upd…

…ate_api Fixes a bug that prevents cohesive usage of booleans and another bug …
Comcast · Jul 14, 2016 · 9d1ef9d · 9d1ef9d
2 parents e41b3e4 + 0026201
commit 9d1ef9d
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/traffic_ops/app/lib/API/DeliveryService.pm b/traffic_ops/app/lib/API/DeliveryService.pm
@@ -582,9 +582,9 @@ sub check_params {
 	}
 
 	if ( defined($params->{active}) ) {
-		if ( $params->{active} eq "true" ) {
+		if ( $params->{active} eq "true" || $params->{active} == 1 ) {
 			$transformed_params->{active} = 1;
-		} elsif ( $params->{active} eq "false" ) {
+		} elsif ( $params->{active} eq "false" || $params->{active} == 0 ) {
 			$transformed_params->{active} = 0;
 		} else {
 			return (undef, "active must be true|false." );
@@ -675,9 +675,9 @@ sub check_params {
 	}
 
 	if ( defined($params->{logsEnabled}) ) {
-		if ( $params->{logsEnabled} eq "true" ) {
+		if ( $params->{logsEnabled} eq "true" || $params->{logsEnabled} == 1 ) {
 			$transformed_params->{logsEnabled} = 1;
-		} elsif ( $params->{logsEnabled} eq "false" ) {
+		} elsif ( $params->{logsEnabled} eq "false" || $params->{logsEnabled} == 0 ) {
 			$transformed_params->{logsEnabled} = 0;
 		} else {
 			return (undef, "logsEnabled must be true|false." );
@@ -697,7 +697,7 @@ sub new_value {
 	my $value = {
 			xml_id                 => $params->{xmlId},
 			display_name           => $params->{displayName},
-			dscp                   => $self->nodef_to_default( $params->{dscp} eq "", 0 ),
+			dscp                   => $self->nodef_to_default( $params->{dscp}, 0 ),
 			signed                 => $self->nodef_to_default( $params->{signed}, 0 ),
 			qstring_ignore         => $params->{qstringIgnore},
 			geo_limit              => $params->{geoLimit},