Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candidate/1.5.7 to Main_1.x #123

Merged
merged 5 commits into from
May 9, 2023
Merged

Candidate/1.5.7 to Main_1.x #123

merged 5 commits into from
May 9, 2023

Conversation

rmigneco
Copy link
Collaborator

@rmigneco rmigneco commented May 9, 2023 •
edited
Loading

Description

This PR brings in changes to update the processing rule for Resources in Swift Package manager.

Change Notes

  • Update Package manifest for processing rules
  • Updated Marketing Version and Version in txt file

Pre-submission Checklist

  • I ran the unit tests locally before checking in.
  • I made sure there were no compiler warnings before checking in.
  • I have written useful documentation for all public code.
  • I have written unit tests for this new feature.

@rmigneco rmigneco changed the title Candidate/1.5.7 Candidate/1.5.7 to Main May 9, 2023
@rmigneco rmigneco changed the title Candidate/1.5.7 to Main Candidate/1.5.7 to Main_1.x May 9, 2023
snayrouz
snayrouz approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@snayrouz snayrouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if this was a minor version change, per semantic versioning, or a patch change, like you've noted with 1.5.7

Other than that, looks good.

@rmigneco rmigneco merged commit 7c926fd into main_1.x May 9, 2023
@rmigneco rmigneco deleted the candidate/1.5.7 branch May 9, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snayrouz snayrouz snayrouz approved these changes

Assignees

@snaggled snaggled

@snayrouz snayrouz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmigneco @snayrouz @snaggled