This repository was archived by the owner on Apr 14, 2020. It is now read-only.
Vanilla Vehicles Expanded Patches #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMMiracles
previously approved these changes
Apr 2, 2020
There was a problem hiding this comment.
We can argue the delicate balance of man vs car when it comes to the authenticity CE strides to add but after testing I can confirm that it has no issues in the error logging. I can also confirm that you can technically win a fist fight against a car if you manage to punch out the tires fast enough.
N7Huntsman
suggested changes
Apr 4, 2020
Patches/Vanilla Animals Expanded - Vehicles/ThingDefs_Races/Races_AFVehicles.xml
Outdated
Show resolved
Hide resolved
N7Huntsman
suggested changes
Apr 5, 2020
| <value> | ||
| <tools> | ||
| <li Class="CombatExtended.ToolCE"> | ||
| <label>head</label> |
There was a problem hiding this comment.
This should probably be swapped to something else, given that the vehicles don't have "heads". Something like grille? body?
There was a problem hiding this comment.
Ahh, nice catch. Should be fixed now, consistent with base mod.
N7Huntsman
approved these changes
Apr 6, 2020
|
@MMMiracles If you think it's good to go, please put an Approval on it under reviews, and I'll get it merged. |
ghost
approved these changes
Apr 7, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Added patches for Vanilla Vehicles Expanded, for races and bodydef
Reasoning
Melee is roughly centipede level for the "strongest" vehicles, scaling down for other ones. They are cars after all, and although it's probably a little over scaled, I don't think this is either a serious mod, or a serious concern. Also cars should be fairly dangerous if they run into a human, even if not at full speed.
Testing
Check tests you have performed: