This repository has been archived by the owner on Apr 14, 2020. It is now read-only.
Fix for #1038 (generateAllowChance instead of generateCommonality) #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Alicecomma
commented
Feb 21, 2020
Alicecomma
commented
- 17 months ago, during RW version change, the code in the method was changed to generateCommonality from a completely different tag which doesn't exist anymore
- generateAllowChance is commonly used to prevent things from being generated, while generateCommonality is not for preventing, just for weighting
- All CE XML uses generateAllowChance, not generateCommonality
- Therefore, this code change is necessary
- 17 months ago, during RW version change, the code in the method was changed to generateCommonality from a completely different tag which doesn't exist anymore - generateAllowChance is commonly used to prevent things from being generated, while generateCommonality is not for preventing, just for weighting - All CE XML uses generateAllowChance, not generateCommonality - Therefore, this code change is necessary
Alicecomma
changed the title
|
To test: Check that Arrows and GreatArrows do not spawn their Plasteel variant |
zozilin
approved these changes
Feb 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.