Skip to content
This repository has been archived by the owner on Apr 14, 2020. It is now read-only.

Alt.: GrenadeRecipeBase sets recipeUsers; some ammo uses GrenadeRecipeBase #975

Closed
rimpy-custom opened this issue Feb 7, 2020 · 6 comments
Assignees
Labels
XML Requires XML solution

Comments

@rimpy-custom
Copy link

Looks like there are four types of ammo that are not used anywhere in Combat Extended but you are able to craft them on machining table:
100x691mm HE
100x691mm HEAT
120mm HE
120mm HEAT
Probably, should be deleted from Defs or moved to appropriate patch.

@rimpy-custom
Copy link
Author

Not an issue of CE, but CE:FT.

@Alicecomma
Copy link
Contributor

Alicecomma commented Feb 19, 2020

With merge of CE:FT (#1006) should be investigated

  • Replicated with PR

Of note:

  • 100x695mmR as well as 120mm have recipedefs with GrenadeRecipeBase. All other shells have AmmoRecipeBase, and these do not have the issue.

Issue:

  • GrenadeRecipeBase sets recipeUsers in XML. It should not, this should be handled by trade tags.

@Alicecomma Alicecomma reopened this Feb 19, 2020
@Alicecomma Alicecomma changed the title Redundant 100x691mm and 120mm shells Alt.: GrenadeRecipeBase sets recipeUsers; some ammo uses GrenadeRecipeBase Feb 19, 2020
@Alicecomma Alicecomma added the XML Requires XML solution label Feb 19, 2020
@Alicecomma
Copy link
Contributor

The 1.1 "60mm mortar shells" have the same problem, they should not use GrenadeRecipeBase. They should use AmmoRecipeBase.

@N7Huntsman
Copy link
Contributor

@Alicecomma I've corrected the ammo recipe base for the 100mmR and 120mm in #1136

However, 60mm does not currently use 'GrenadeRecipeBase' and since I used the 81mm .xml file as a template, I suspect it never has.

Alicecomma added a commit that referenced this issue Mar 26, 2020
- Make 100x695 and 120mm disappear
@Alicecomma
Copy link
Contributor

The 60mm shell is probably due to the weapon being considered a turret gun, so the destroyOnDrop is not checked -- OR, the weapon isn't destroyOnDrop.

@N7Huntsman
Copy link
Contributor

All cases in core ammo and integrated patches has been solved. The issue with the 60mm was unrelated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
XML Requires XML solution
Projects
None yet
Development

No branches or pull requests

3 participants