[Fix in #1039] Reloading a weapon does not update its weight/bulk values.

[Tostov]

When reloading a weapon, the ammo's mass/bulk that is loaded into the gun is not accounted for after the reload, until the inventory is altered again (e.g. picking up/dropping a item, shooting a weapon, equipping a different weapon.)

[Tostov]

A simmilar issue occurs when unloading a weapon as well. The previously loaded ammo is added to the inventory, but its bulk/mass from being loaded in the gun remains until the inventory is altered again.

[Alicecomma]

The issue suggests that there's a missing CompInventory.UpdateInventory call in CompAmmoUser.LoadAmmo:

LoadAmmo considers the case of ammo == null (unloading) without any calls to UpdateInventory. So, a fix would be to add "if (CompInventory != null) CompInventory.UpdateInventory();".
Similarly, LoadAmmo considers the case where all ammo in the inventory is used up without any calls to UpdateInventory.

[Alicecomma]

Further inspection:

• Loading a weapon decreases inventory mass/bulk but doesn't change weapon mass/bulk
• Unloading increases mass/bulk but doesn't change weapon mass/bulk
• Dropping a weapon and equiping it again DOES check whether the weapon is loaded, adding mass/bulk for the loaded weapon: CompInventory.GetEquipmentStats considers loaded bullet weights.

---

An alternative way to fix this issue is to have a statworker for both mass and bulk, which takes into consideration loaded bullets. This way, loaded guns are heavier also in caravans. This is the desired change:

• Add StatWorker_Mass, which considers loaded rounds
• Add StatWorker_Bulk, which considers loaded rounds

---

The issue with such a change is that if there's other mods with custom StatWorker for Mass or Bulk, they are not accounted for properly. Perhaps there's an alternative way to update these stats on a Thing level.

[Alicecomma]

Simplified the StatWorker stuff into a single StatWorker_LoadedAmmo, which considers Mass or Bulk separately for whatever stat (mass or bulk) it is attached to. This means that any StatDef could re-use this method of accessing loaded projectiles.

[Alicecomma]

Issue to be resolved:

• Add XML tag to weapons to decide whether loading ammo into them increases bulk/wornbulk
  Added XML tag "loadedAmmoBulkFactor" to CompProperties_AmmoUser. Intended use:

<Operation Class="CombatExtended.PatchOperationMakeGunCECompatible">
    <defName>CE_Gun_RPGSeven</defName>
    <AmmoUser>
        <loadedAmmoBulkFactor>1</loadedAmmoBulkFactor>
    </AmmoUser>
</Operation>

<ThingDef ParentName="BaseMakeableGun">
    <defName>CE_Gun_RPGSeven</defName>
    <comps>
        <li Class="CombatExtended.CompProperties_AmmoUser">
            <loadedAmmoBulkFactor>1</loadedAmmoBulkFactor>
        </li>
    </comps>
</ThingDef>