Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set input elements to autocomplete="off" to prevent browser autofill #11192

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

banobepascal
Copy link

Change-Id: I0c86a21b95babf866a49d3db9800cd3be45e929a

  • Target version: master

Summary

This adds autocomplete="off" to input elements including radio buttons, checkboxes, spinfields and text inputs. This prevents unwanted browser autofill behavior and native browser popups that can interfere with the application's form handling.

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@banobepascal banobepascal force-pushed the private/banobepascal/input-autocomplete-off branch 2 times, most recently from a8b3740 to b4ab673 Compare February 18, 2025 18:13
@pedropintosilva pedropintosilva removed their request for review February 18, 2025 19:13
@banobepascal banobepascal force-pushed the private/banobepascal/input-autocomplete-off branch from b4ab673 to 12f91ac Compare February 19, 2025 09:44
This adds autocomplete="off" to input elements including form and text inputs.
This prevents unwanted browser autofill behavior and native browser popups
that can interfere with the application's form handling.

Signed-off-by: Banobe Pascal <[email protected]>
Change-Id: Ia1c70d76f7cc8b258eb1a4dacf400bcd077a327a
@banobepascal banobepascal force-pushed the private/banobepascal/input-autocomplete-off branch from 12f91ac to 53cdebd Compare February 20, 2025 07:19
Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good :)

@eszkadev eszkadev merged commit 566eed5 into master Feb 20, 2025
14 checks passed
@eszkadev eszkadev deleted the private/banobepascal/input-autocomplete-off branch February 20, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants