Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status bar: hide on/off indicators if they have default values #11186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

banobepascal
Copy link

Change-Id: Iec53e53cc820fe14c3a5657b80e59b5d01b26a5a

Summary

Add data-default attribute to status elements to hide indicators when they are in default state:

  • InsertMode when the value is 'Insert'
  • showcomments when the value is 'Comments: On'
  • permissionmode when the value is 'Edit mode'
  • StatusSelectionMode when the value is 'Standard selection'

Previews

Screenshot from 2025-02-17 22-29-36

Add data-default attribute to status elements to hide indicators when
they are in default state:

 - InsertMode when the value is 'Insert'
 - showcomments when the value is 'Comments: On'
 - permissionmode when the value is 'Edit mode'
 - StatusSelectionMode when the value is 'Standard selection'

Signed-off-by: Banobe Pascal <[email protected]>
Change-Id: Iec53e53cc820fe14c3a5657b80e59b5d01b26a5a
'InsertMode',
_('Entering text mode'),
text,
text === 'Insert',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not work. We get translated strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Review
Development

Successfully merging this pull request may close these issues.

Status bar: Hide on/off Indicators if they have default values
2 participants