tiles: avoid duplicated version bump #11171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
force-pushed
the
private/eszkadev/tiles-duplicates
branch
from
85fdc67 to
9efce68
Compare
Related to issue #10980 Followup for 6ae718e tiles: client cannot force keyframe Version can protect us from rendering the same tile twice. The increase was introduced in commit 5260eae Avoid rendering / sending the same tile twice Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I2c596abca8269c30d3da88dbafd336acc11b1d32
When we send tilecombine request we increased version inside for loop - on every tile. We should keep the same version on all of them and combine only tiles which have the same version. The increment comes from commit 5260eae Avoid rendering / sending the same tile twice BEFORE: TRC TileCombined request for nviewid=1000 part=1 width=256 height=256 tileposx=0,3840,7680,11520,15360,19200,0,3840,7680,11520,15360,19200,0,3840,7680,11520,15360,19200 tileposy=0,0,0,0,0,0,3840,3840,3840,3840,3840,3840,7680,7680,7680,7680,7680,7680 tilewidth=3840 tileheight=3840 ver=-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1 from client| wsd/DocumentBroker.cpp:4371 all have version: -1 forcing a keyframe for tilecombined tile (1,0,0,0).| wsd/DocumentBroker.cpp:4394 Forcing keyframe for tile was oldwid 0| wsd/DocumentBroker.cpp:4590 Subscribing ToClient-038 to tile (1000,1,0,0,0) ver=1 ... forcing a keyframe for tilecombined tile (1,0,3840,0).| wsd/DocumentBroker.cpp:4394 Forcing keyframe for tile was oldwid 0| wsd/DocumentBroker.cpp:4590 Subscribing ToClient-038 to tile (1000,1,0,3840,0) ver=2 ... AFTER: TRC TileCombined request for nviewid=1000 part=1 width=256 height=256 tileposx=0,3840,7680,11520,15360,19200,0,3840,7680,11520,15360,19200,0,3840,7680,11520,15360,19200 tileposy=0,0,0,0,0,0,3840,3840,3840,3840,3840,3840,7680,7680,7680,7680,7680,7680 tilewidth=3840 tileheight=3840 ver=-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1 from client| wsd/DocumentBroker.cpp:4371 all have version: -1 forcing a keyframe for tilecombined tile (1,0,0,0).| wsd/DocumentBroker.cpp:4395 Forcing keyframe for tile was oldwid 0| wsd/DocumentBroker.cpp:4591 Subscribing ToClient-035 to tile (1000,1,0,0,0) ver=1 ... forcing a keyframe for tilecombined tile (1,0,3840,0).| wsd/DocumentBroker.cpp:4395 Forcing keyframe for tile was oldwid 0| wsd/DocumentBroker.cpp:4591 Subscribing ToClient-035 to tile (1000,1,0,3840,0) ver=1 ... Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I2b074926b86f93bc611c0cc611d1988daf368902
eszkadev
force-pushed
the
private/eszkadev/tiles-duplicates
branch
from
9efce68 to
96b135e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #10980
Followup for 6ae718e
tiles: client cannot force keyframe
Version can protect us from rendering the same tile twice. The increase was introduced in commit 5260eae Avoid rendering / sending the same tile twice