browser: accessibility: ensure to create only single instance #11137
Conversation
hcvcastro
force-pushed
the
pr/master/A3
branch
2 times, most recently
from
55ba625 to
0421a7c
Compare
hcvcastro
force-pushed
the
pr/master/A3
branch
from
0421a7c to
d427406
Compare
| @@ -414,7 +414,7 @@ var NotebookbarAccessibility = function() { | |||
|
|
|||
| this.initialize = function() { | |||
| setTimeout(function() { | |||
| if (window.mode.isDesktop()) { | |||
| if (window.mode.isDesktop() && !this.initialized) { | |||
There was a problem hiding this comment.
what about switching the mode few times?
tabbed interface -> compact interface -> tabbed interface
it will not be reinitialized again probably?
this is called in Control.UIManager.js
There was a problem hiding this comment.
possibly we need to "reset" it on switching to classic mode / closing tabbed interface
There was a problem hiding this comment.
what about switching the mode few times? tabbed interface -> compact interface -> tabbed interface
it will not be reinitialized again probably? this is called in Control.UIManager.js
I have no idea, how coded/design here. I just saw an inconsistency here. It looks like a life cycle issue. I supposed
it is a singleton.
There was a problem hiding this comment.
possibly we need to "reset" it on switching to classic mode / closing tabbed interface
The user can change dynamically user interface without reload?
There was a problem hiding this comment.
yes, view -> compact mode / tabbed mode
There was a problem hiding this comment.
Ok, you designed the control. I just did a quick fix, no depth analysis here, I have spotted a serious issue here. It is up to you guys to decide what is best.
|
Deleting the class instance and re-creating sounds like a better solution btw. It may prevent future issues. |
hcvcastro
force-pushed
the
pr/master/A3
branch
from
d427406 to
ecdef71
Compare
Yes, It is a definitive solution. Please add your patches when it is merged |
hcvcastro
force-pushed
the
pr/master/A3
branch
3 times, most recently
from
4f63f30 to
b3fe10f
Compare
|
#11193 has to go in first, then please rebase. Sorry about the trouble. |
Otherwise it will create a possible pattern: <div style="height: 0px; width: 0px; overflow: hidden;"><input type="submit" role="tablist" id="accessibilityInputElement" autocomplete="off" style="height: 0px; width: 0px;"></div> <div style="height: 0px; width: 0px; overflow: hidden;"><input type="submit" role="tablist" id="accessibilityInputElement" autocomplete="off" style="height: 0px; width: 0px;"></div> <div style="height: 0px; width: 0px; overflow: hidden;"><input type="submit" role="tablist" id="accessibilityInputElement" autocomplete="off" style="height: 0px; width: 0px;"></div> <div style="height: 0px; width: 0px; overflow: hidden;"><input type="submit" role="tablist" id="accessibilityInputElement" autocomplete="off" style="height: 0px; width: 0px;"></div> <div style="height: 0px; width: 0px; overflow: hidden;"><input type="submit" role="tablist" id="accessibilityInputElement" autocomplete="off" style="height: 0px; width: 0px;"></div> <div style="height: 0px; width: 0px; overflow: hidden;"><input type="submit" role="tablist" id="accessibilityInputElement" autocomplete="off" style="height: 0px; width: 0px;"></div> <div style="height: 0px; width: 0px; overflow: hidden;"><input type="submit" role="tablist" id="accessibilityInputElement" autocomplete="off" style="height: 0px; width: 0px;"></div> <div style="height: 0px; width: 0px; overflow: hidden;"><input type="submit" role="tablist" id="accessibilityInputElement" autocomplete="off" style="height: 0px; width: 0px;"></div> <div style="height: 0px; width: 0px; overflow: hidden;"><input type="submit" role="tablist" id="accessibilityInputElement" autocomplete="off" style="height: 0px; width: 0px;"></div> Change-Id: I54f09b50a0cef1f228c361ebefbd5b47cd35e2be Signed-off-by: Henry Castro <[email protected]>
hcvcastro
force-pushed
the
pr/master/A3
branch
from
b3fe10f to
cafb478
Compare
Otherwise it will create a possible pattern:
Change-Id: I54f09b50a0cef1f228c361ebefbd5b47cd35e2be
Signed-off-by: Henry Castro [email protected]