Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Youtube: fix the art URL and the position #227

Merged
merged 1 commit into from
May 7, 2018
Merged

Youtube: fix the art URL and the position #227

merged 1 commit into from
May 7, 2018

Conversation

NicolasGuilloux
Copy link
Contributor

@NicolasGuilloux NicolasGuilloux commented May 6, 2018

Fixes

This fixes the wrong art URL and the actual position of the indicator. Moreover, it supports playlists with next/previous buttons and also volume indicator.
It mostly uses the YouTube API to avoid using graphical elements that can be changed.
The previous button works only in playlists.

Proposed Changes

  • indicator.js of the YouTube plugin

This fixes the wrong art URL and the actual position of the indicator. Moreover, it supports playlists with next/previous buttons and also volume indicator.
It mostly uses the YouTube API to avoid using graphical elements that can be changed.
The previous button works only in playlists.
@ColinDuquesnoy ColinDuquesnoy changed the title Fix the art URL and the position Youtube: fix the art URL and the position May 7, 2018
@ColinDuquesnoy ColinDuquesnoy self-requested a review May 7, 2018 08:37
Copy link
Owner

@ColinDuquesnoy ColinDuquesnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Using the youtube API is the way to go. Thank you very much!

@ColinDuquesnoy ColinDuquesnoy merged commit 07feab9 into ColinDuquesnoy:develop May 7, 2018
@ColinDuquesnoy ColinDuquesnoy self-assigned this May 7, 2018
@ColinDuquesnoy ColinDuquesnoy added this to the 3.4.0 milestone May 7, 2018
@cpjeanpaul cpjeanpaul mentioned this pull request Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants