Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Add Yandex Music support #223

Merged
merged 6 commits into from
Apr 22, 2018

Conversation

rustamzh
Copy link
Contributor

Implemented major features, but not sure about artUrl. In Yandex Music art url has format:

avatars.yandex.net/get-music-content/63210/e4668dc0.a.2188647-1/200x200

But I have not seen MellowPlayer display any.

@ColinDuquesnoy
Copy link
Owner

Nice! Thank you!

About the artUrl issue, may I ask you to post the logs (run with --log-level 1 or 0 if you don't see meaningful information).

@DmMlhch
Copy link
Contributor

DmMlhch commented Apr 19, 2018

Regarding the album art: looks like the only way to get it working is to add "https://" to the URL reported by Yandex Music's API.
I've also noticed one more bug - null reference errors in update( ) function when the queue is empty. I can send PR tomorrow to fix this

@rustamzh rustamzh force-pushed the yandexmusic_support branch from 6ffa432 to 319966b Compare April 20, 2018 03:19
@rustamzh
Copy link
Contributor Author

@ColinDuquesnoy Also seen in logs null reference errors, but I attribute them that js file with Yandex API is not loaded yet. Is there any special way to stub the update until API is loaded?

@rustamzh
Copy link
Contributor Author

The only error left in logs is this line:
[E] [2018-04-20 09-58-07:146549] [js] 20 9:58:07 AM.138
I have checked log-level 1 and 0 and did not get much info than this.

@ColinDuquesnoy
Copy link
Owner

@rustamzh The error might be coming from yandex itself, do you have a similar warning in the JS console of chrome or firefox?

@rustamzh
Copy link
Contributor Author

@ColinDuquesnoy Just verified. Indeed I have. It is error similar to the error from the script that detects adblock

Copy link
Owner

@ColinDuquesnoy ColinDuquesnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except the logo. Do you think you can adapt the logo's color and style to match the logo of other services? If you're not good at this kind of stuff, just let me know and I'll ask @CelineThiry to make the necessary adaptations.

@rustamzh
Copy link
Contributor Author

@ColinDuquesnoy I did my best

@ColinDuquesnoy ColinDuquesnoy merged commit a109ce3 into ColinDuquesnoy:develop Apr 22, 2018
@ColinDuquesnoy
Copy link
Owner

Nice, thank you for your contribution!

@cpjeanpaul cpjeanpaul mentioned this pull request Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants