Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Google Play Music: handle cases when we can't go to next/previous #222

Merged

Conversation

DmMlhch
Copy link
Contributor

@DmMlhch DmMlhch commented Apr 13, 2018

Proposed Changes

GPM Plugin - properly handle cases when we can't go to next/previous.

Example: when repeat is disabled and the last track in the queue finishes playing GPM disables next and previous buttons and clicking on them does nothing (play button still works).

MellowPlayer should handle such cases correctly so that it does not display active next and previous buttons in it's toolbar/MPRIS applet when it can't actually skip to next/previous song

@ColinDuquesnoy ColinDuquesnoy self-assigned this Apr 13, 2018
@ColinDuquesnoy ColinDuquesnoy added this to the 3.4.0 milestone Apr 13, 2018
@ColinDuquesnoy ColinDuquesnoy merged commit 65d18a5 into ColinDuquesnoy:develop Apr 13, 2018
@ColinDuquesnoy
Copy link
Owner

Thank you!

MellowPlayer should handle such cases correctly so that it does not display active next and previous buttons in it's toolbar/MPRIS applet when it can't actually skip to next/previous song

I've tested with deezer, MellowPlayer disable the next/previous buttons correctly in the toolbar (the button is semi transparent to indicate it cannot be used). Are you saying this does not work for you or do you mean they should be hidden instead of being disabled?

@DmMlhch
Copy link
Contributor Author

DmMlhch commented Apr 13, 2018

Are you saying this does not work for you or do you mean they should be hidden instead of being disabled?

My comment is only relevant for that particular case in Google Play Music

when repeat is disabled and the last track in the queue finishes playing GPM disables next and previous buttons and clicking on them does nothing (play button still works).

In this scenario next and previous buttons were not semi transparent without this commit. In other services (e.g. Youtube) it works as expected.

@ColinDuquesnoy
Copy link
Owner

Ok, I misunderstood your last sentence. Thank you for your contribution!

@ColinDuquesnoy ColinDuquesnoy changed the title GPM - handle cases when we can't go to next/previous GPM: handle cases when we can't go to next/previous May 8, 2018
@ColinDuquesnoy ColinDuquesnoy changed the title GPM: handle cases when we can't go to next/previous Google Play Music: handle cases when we can't go to next/previous May 8, 2018
@cpjeanpaul cpjeanpaul mentioned this pull request Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants