Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Add favorites support to soundcloud plugin #134

Merged
merged 2 commits into from
Oct 21, 2017
Merged

Add favorites support to soundcloud plugin #134

merged 2 commits into from
Oct 21, 2017

Conversation

Cogitri
Copy link
Contributor

@Cogitri Cogitri commented Oct 20, 2017

This PR adds support for adding a song to one's favorites on SoundCloud

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.746% when pulling c29d607 on Cogitri:soundcloud-like into fd7b651 on ColinDuquesnoy:develop.

@ColinDuquesnoy
Copy link
Owner

Thank you!

Do you think it is possible to implement removeFromFavorites as well? Usually if add is possible, remove should be possible too...

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.746% when pulling 3addf18 on Cogitri:soundcloud-like into fd7b651 on ColinDuquesnoy:develop.

@ColinDuquesnoy ColinDuquesnoy merged commit a5e7ab2 into ColinDuquesnoy:develop Oct 21, 2017
@ColinDuquesnoy
Copy link
Owner

Thank you!

@cpjeanpaul cpjeanpaul mentioned this pull request Jul 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cogitri @coveralls @ColinDuquesnoy