Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Internationalisation #52

Closed
ColinDuquesnoy opened this issue May 28, 2017 · 21 comments
Closed

Internationalisation #52

ColinDuquesnoy opened this issue May 28, 2017 · 21 comments
Assignees
Milestone

Comments

@ColinDuquesnoy
Copy link
Owner

Add support for internationalisation (use qtlinguist or transifex)

@ColinDuquesnoy ColinDuquesnoy added this to the 3.0 final milestone May 28, 2017
@ColinDuquesnoy ColinDuquesnoy self-assigned this May 28, 2017
ColinDuquesnoy added a commit that referenced this issue Jun 24, 2017
Window is hidden when the user click on close (or alt+f4), user can restore the window by clicking on the tray icon and quit using Ctrl+Q or the tray icon quit context menu action
ColinDuquesnoy added a commit that referenced this issue Jun 24, 2017
Add tests that make sure the tray icon is shown when the application is initialized
ColinDuquesnoy added a commit that referenced this issue Jul 29, 2017
Works with one string translated to French

Will use the language of the OS. I don't plan to add a setting to change the language.
ColinDuquesnoy added a commit that referenced this issue Jul 29, 2017
Works with one string translated to French

Will use the language of the OS. I don't plan to add a setting to change the language.
ColinDuquesnoy added a commit that referenced this issue Jul 29, 2017
Empty spanish and german translations
@ColinDuquesnoy
Copy link
Owner Author

@ZeroDot1 I've just uploaded the resources needed for translating mellow player on transifex

Wiki page has been updated: https://github.com/ColinDuquesnoy/MellowPlayer/wiki/%5BTutorial%5D-Adding-or-updating-a-translation.

I'll close this issue once the French translation is ready (so that I am sure all parts of the application are translatable)

@ZeroDot1
Copy link
Contributor

I am working on the German translation.
I send the files when I'm done with the translation.
bildschirmfoto_2017-07-29_17-58-32

@ColinDuquesnoy
Copy link
Owner Author

ColinDuquesnoy commented Jul 29, 2017

@ZeroDot1

Good! 👍

You can do it using QtLinguist but I'd prefer if you use transifex. It's easier to pull your changes and discuss potential issue or talk about the string to translate there (there is a forum and you can also add some comments to a specific string).

@ColinDuquesnoy
Copy link
Owner Author

ColinDuquesnoy commented Jul 29, 2017

@ZeroDot1 Also wait a bit for the sources to be clean. I've realized the first source I pushed contained the strings from QtWebEngine too (we should not translate these). The resource on transifex is already up to date but I see in your screenshot that you don't.

ColinDuquesnoy added a commit that referenced this issue Jul 29, 2017
Pull from transifex, remove all obsoletes translation
ColinDuquesnoy added a commit that referenced this issue Jul 29, 2017
Note that settings are currently not translatable (need some work to move some string from Json to C++)
ColinDuquesnoy added a commit that referenced this issue Jul 29, 2017
@ZeroDot1
Copy link
Contributor

Automatic language selection does not work.

 '/home/user/MellowPlayer-develop/MellowPlayer-develop/src/MellowPlayer'
qt5ct: using qt5ct plugin
[I] [2017-07-29 22-50-12:046888] [main] Log directory: /home/user/.local/share/MellowPlayer/MellowPlayer/Logs/
[I] [2017-07-29 22-50-12:047023] [main] MellowPlayer 2.95.0.0 - Built on Jul 29 2017 at 22:29:09 (GCC 7.1.1 20170630, 64 bit) with Qt 5.9.1
[I] [2017-07-29 22-50-12:047194] [qt] translation successfully loaded:  "de_DE"
[W] [2017-07-29 22-50-14:648987] [qt] <Unknown File>: QML QQuickAnchors: Binding loop detected for property "rightMargin"
[WARNING:flash/platform/pepper/pep_module.cpp(63)] SANDBOXED

Screenshot:
bildschirmfoto_2017-07-29_23-15-10

@ColinDuquesnoy
Copy link
Owner Author

@ZeroDot1 Sorry I accidentally pushed some code that forced loading of the french translation. Should be fixed now.

FYI there are some parts of the application that are not translatable yet (e.g. the settings page). I am working on it. There will be more strings to translate when I'm done.

ColinDuquesnoy added a commit that referenced this issue Jul 30, 2017
Remove _fr.ts, _de.ts and _es.ts sources (keep country specific translations: fr_FR, de_DE, es_ES,...)

Use MellowPlayer_en.ts as the source for all translations on transifex
@ZeroDot1
Copy link
Contributor

Thanks for the update :)
bildschirmfoto_2017-07-30_11-35-55

@ZeroDot1
Copy link
Contributor

So I change now to my Transifex account for future translation in German, the basis is now created.

@ColinDuquesnoy
Copy link
Owner Author

👍 OK, I'll let you know when you can start working on them.

@ZeroDot1
Copy link
Contributor

Thank you:)

ColinDuquesnoy added a commit that referenced this issue Jul 30, 2017
Now every parts of the UI is translatable.
@ColinDuquesnoy
Copy link
Owner Author

@ZeroDot1 You can start working on the remaining translations, the application can now be fully translated.

Comment on this forum page if you encounter any issues or if you want me to pull your work from transifex: https://www.transifex.com/colinduquesnoy/teams/59776/discussions/17913/

ColinDuquesnoy added a commit that referenced this issue Jul 30, 2017
Fix warning when loading en translation, qt wants at least one finished string.
@ZeroDot1
Copy link
Contributor

The German translation is ready.
You can integrate it into MellowPlayer.
:)

@ColinDuquesnoy
Copy link
Owner Author

Thank you for the quick update! I integrated into the git repo (commit 8d6f876)

@ColinDuquesnoy
Copy link
Owner Author

@ZeroDot1

The system tray icon is now translatable. Comment here when you're done and feel free to reopen this issue if you find some other places that are not translatable.

I'll wait till the end of the week to publish version 3.0 final.

@ZeroDot1
Copy link
Contributor

I've finished :)
I have tested the translations, but everything should be correct.

You can integrate it into MellowPlayer.

Do not forget to update the version history before the release, and the website [ @CelineThiry ]

@ColinDuquesnoy
Copy link
Owner Author

@ZeroDot1 I found another place where there was a missing translation: the "Open" action of libnotify's notifications.

I updated the translation source on transifex.

@ZeroDot1
Copy link
Contributor

ZeroDot1 commented Aug 6, 2017

Ok, I'm going to translate that.

I have also found something, the confirmation dialog is not completely translated into German.
Screenshot:
bildschirmfoto_2017-08-06_14-46-31

@ColinDuquesnoy
Copy link
Owner Author

Good catch! I have updated the translation source on transifex.

@ZeroDot1
Copy link
Contributor

ZeroDot1 commented Aug 6, 2017

The translation is ready, thanks for the quick update :)

@ZeroDot1
Copy link
Contributor

ZeroDot1 commented Aug 7, 2017

Sorry,
The plug-in wizard is not yet fully translated.
Screenshot:
bildschirmfoto_2017-08-07_19-11-57

@ColinDuquesnoy
Copy link
Owner Author

Thank you for reporting. I created a new issue (attached to the final release milestone: 3.0.0). Please create new issues if you find other places that are not translatable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants