mellowplayer.desktop does not pass desktop-file-validate

[probonopd]

desktop-file-validate does not pass mellowplayer.desktop for the following reasons:

• mellowplayer.desktop: error: value "3.0" for key "Version" in group "Desktop Entry" is not a known version
• mellowplayer.desktop: hint: value "AudioVideo;Network;" for key "Categories" in group "Desktop Entry" contains more than one main category; application might appear more than once in the application menu
• mellowplayer.desktop: warning: value "Cloud music player" for key "Comment" in group "Desktop Entry" looks redundant with value "Cloud music player" of key "GenericName"
• mellowplayer.desktop: warning: value "Lecteur de services de musique en ligne" for key "Comment[fr]" in group "Desktop Entry" looks redundant with value "Lecteur de services de musique en ligne" of key "GenericName[fr]"
• mellowplayer.desktop: error: value "PlayPause;Next;Previous;Restore" for string list key "Actions" in group "Desktop Entry" does not have a semicolon (';') as trailing character
• mellowplayer.desktop: error: action group "Desktop Action Restore" exists, but there is no matching action "Restore"
• mellowplayer.desktop: error: action group "Desktop Action PlayPause" exists, but there is no matching action "PlayPause"
• mellowplayer.desktop: error: action group "Desktop Action Next" exists, but there is no matching action "Next"
• mellowplayer.desktop: error: action group "Desktop Action Previous" exists, but there is no matching action "Previous"

References:
https://travis-ci.org/AppImage/AppImageHub/builds/266141180#L502-L510

[ColinDuquesnoy]

mellowplayer.desktop now passes desktop-file-validate on my system (OpenSuse Tumbleweed) but I didn't get the last 4 errors. Report back if you still have those issues on travis and I'll reopen.

[probonopd]

9880e8a seems to be missing from GitHub Releases continuous, do you know why?

[ColinDuquesnoy]

Yes, a commit build does not build a package and does not update the continuous release on github. This is done only in a full build triggered by a daily cron job or manually via the travis api. I've just triggered a new full build for you to try.

[probonopd]

Unfortunately still getting errors. This is on Ubuntu trusty.

URL from GitHub API: https://github.com/ColinDuquesnoy/MellowPlayer/releases/download/Continuous/MellowPlayer-x86_64.AppImage
URL: https://github.com/ColinDuquesnoy/MellowPlayer/releases/download/Continuous/MellowPlayer-x86_64.AppImage
(...)
/tmp/.mount_appimaWdzjG9/mellowplayer.desktop: error: value "1.1" for key "Version" in group "Desktop Entry" is not a known version
/tmp/.mount_appimaWdzjG9/mellowplayer.desktop: error: value "AudioVideo" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Please remove the Version= line or set it to 1.0, and add a ; behind AudioVideo.

https://travis-ci.org/AppImage/AppImageHub/builds/266317327#L535-L544

[ColinDuquesnoy]

Ok. Please try again.

[probonopd]

Thanks. Did you test with desktop-file-validate?

Now getting FATAL: Key Icon is not in .desktop file exactly once here.

[ColinDuquesnoy]

Yes, it pass on my system:

[19:33:02] colin@localhost /home/colin/Projects/MellowPlayer (0) 
> desktop-file-validate share/applications/mellowplayer.desktop
[19:33:05] colin@localhost /home/colin/Projects/MellowPlayer (0) 
> desktop-file-validate --help
Usage:
  desktop-file-validate [OPTION?] <desktop-file>...

Validate desktop entry files according to the Desktop Entry specification 1.1.
For information about this specification, see:
	http://freedesktop.org/wiki/Specifications/desktop-entry-spec

Help Options:
  -h, --help               Show help options

Application Options:
  --no-hints               Do not output hints to improve desktop file
  --no-warn-deprecated     Do not warn about usage of deprecated items
  --warn-kde               Warn if KDE extensions to the specification are used

There are indeed more than one Icon key, one for the application and one foreach desktop action. Looks like the desktop-file-validate you use does not support/understand desktop action well. I'd suggest using a more recent version of desktop-file-validate.

[probonopd]

OK, looks like I need to do that, yes. Thank you very much.