Make MultiAuth public API. #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hello, we advocate for a single way to create new multi auth. meaning using already exposed SupportMultiAuth as in https://github.com/Colin-b/httpx_auth?tab=readme-ov-file#multiple-authentication-at-once current implementation is using multiauth class but we would like to keep it internal to change this if needed in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpx-auth supports combining auth flows, which is currently handled by implementing SupportsMultiAuth interface. But internally all it does it uses MultiAuth to combine all those Auth instances into one.
This PR exposes MultiAuth, so that any Auth implementation can be directly used as part of this mechanism, e.g. httpx.auth.Digest or any custom Auth classes implemented by users.