Fix @commands.can_manage_channel always passing

[Flame442]

Description of the changes

Red-DiscordBot/redbot/core/commands/requires.py

Lines 791 to 806 in ad1e1aa

	def can_manage_channel(*, allow_thread_owner: bool = False) -> Callable[[_T], _T]:
	"""Restrict the command to users with permissions to manage channel.
	This check properly resolves the permissions for `discord.Thread` as well.
	This check can be overridden by rules.
	Parameters
	----------
	allow_thread_owner: bool
	If ``True``, the command will also be allowed to run if the author is a thread owner.
	This can, for example, be useful to check if the author can edit a channel/thread's name
	as that, in addition to members with manage channel/threads permission,
	can also be done by the thread owner.
	"""
	return _can_manage_channel_deco(allow_thread_owner)

@commands.can_manage_channel passes the bool value allow_thread_owner as the first parameter to _can_manage_channel_deco

Red-DiscordBot/redbot/core/commands/requires.py

Lines 763 to 778 in ad1e1aa

	def _can_manage_channel_deco(
	privilege_level: Optional[PrivilegeLevel] = None, allow_thread_owner: bool = False
	) -> Callable[[_T], _T]:
	async def predicate(ctx: "Context") -> bool:
	if utils.can_user_manage_channel(
	ctx.author, ctx.channel, allow_thread_owner=allow_thread_owner
	):
	return True
	if privilege_level is not None:
	if await PrivilegeLevel.from_ctx(ctx) >= privilege_level:
	return True
	return False
	return permissions_check(predicate)

_can_manage_channel_deco expects the first parameter to be a PrivilegeLevel. When a bool is passed instead, the eventual comparison results in if await PrivilegeLevel.from_ctx(ctx) >= <bool>.

Red-DiscordBot/redbot/core/commands/requires.py

Lines 97 to 117 in ad1e1aa

	class PrivilegeLevel(enum.IntEnum):
	"""Enumeration for special privileges."""
	# Maintainer Note: do NOT re-order these.
	# Each privilege level also implies access to the ones before it.
	# Inserting new privilege levels at a later point is fine if that is considered.
	NONE = enum.auto()
	"""No special privilege level."""
	MOD = enum.auto()
	"""User has the mod role."""
	ADMIN = enum.auto()
	"""User has the admin role."""
	GUILD_OWNER = enum.auto()
	"""User is the guild level."""
	BOT_OWNER = enum.auto()
	"""User is a bot owner."""

Since enum.auto increments starting from 1, and bools are interpreted as an int of 0 or 1, the PrivilegeLevel requirement is always passed. As a result, this check always passes, regardless of the channel state or the permissions of the invoker. This is not the case for all other checks that use the _can_manage_channel_deco helper, as those checks explicitly pass a PrivilegeLevel.

Have the changes in this PR been tested?

Yes

[Jackenmen]