Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Warnings] Add setting for warn channel and DMing warns toggle #2929

Merged
merged 30 commits into from
Mar 12, 2020
Merged

[Warnings] Add setting for warn channel and DMing warns toggle #2929

merged 30 commits into from
Mar 12, 2020

Conversation

Ianardo-DiCaprio
Copy link
Contributor

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This adds commands requested in #2800. It allows to toggle warns being sent to DM's, allows to toggle warns being sent to a channel on a server and has a command to set the channel the warns get sent to, if no channel is set it gets sent to the channel the [p]warn command was used in.

@Flame442 Flame442 added the Type: Enhancement Something meant to enhance existing Red features. label Aug 12, 2019
Copy link
Contributor

@DevilXD DevilXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple of changes.

Also, from the original issue:

(...) option to warn a user (i.e. ping them) in set guild channel and/or just warn that user in channel where the [p]warn command was issued.

This could be slightly hard to understand, at least for me. I've commented on the original issue, but basically - there already is an option to log warnings into the modlog channel. A second channel with warnings only could be made public tho, so I guess there is some logic behind having it like this ¯\_(ツ)_/¯

redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
@Jackenmen Jackenmen self-assigned this Jan 16, 2020
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I know it looks like a lot of review comments, but these are all just minor string improvements =)

redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
changelog.d/warnings/2929.enhance.rst.txt Outdated Show resolved Hide resolved
changelog.d/warnings/2929.enhance.rst Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I didn't notice in first review.
Once this and UX stuff pointed out by Draper gets handled, this should be ready to go.

redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
@FixedThink
Copy link
Contributor

FixedThink commented Jan 25, 2020

Would it be possible to inform the author about the DM not being sent if it's enabled?
If the DM fails, the kick/ban will still succeed, but the bot will send a message like "This user did not receive your case as they have either blocked the bot or disabled DMs." I think this will be much better then just sending a DM without any sort of feedback as of what happened to it.

The reason for this is that (to me at least) it tends to happen that someone says they have never been informed about why they're kicked/muted/whatever, but that there is no way for a staff member to actually verify whether that's true or whether they're 🙈. In other words it would ease a lot of moderation arguments and such, especially with warnings.

@Jackenmen
Copy link
Member

@FixedThink It would be possible but in my opinion this shouldn't be part of this PR, I would advice making a separate issue with a request for this enhancement.

@Jackenmen Jackenmen added Type: Feature New feature or request. and removed Type: Enhancement Something meant to enhance existing Red features. labels Jan 26, 2020
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the only needed change before this can be approved.

redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
redbot/cogs/warnings/warnings.py Outdated Show resolved Hide resolved
@Jackenmen Jackenmen linked an issue Feb 15, 2020 that may be closed by this pull request
3 tasks
@Jackenmen Jackenmen added this to the 3.3.3 milestone Mar 12, 2020
@Jackenmen Jackenmen changed the title [Warnings] Features requested for warnings [Warnings] Add setting for warn channel and DMing warns toggle Mar 12, 2020
@Jackenmen Jackenmen merged commit 2e5dc82 into Cog-Creators:V3/develop Mar 12, 2020
@Jackenmen Jackenmen added the Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. label Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Warnings] Option to disable DMing warns, option to warn in guild channel
6 participants