Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ModLog] Fix get_case() and get_casetype() #2877

Merged
merged 5 commits into from
Jul 15, 2019
Merged

[ModLog] Fix get_case() and get_casetype() #2877

merged 5 commits into from
Jul 15, 2019

Conversation

Tobotimus
Copy link
Member

This fixes [p]reason and [p]case with cases that were created after 3.1.3.

@Tobotimus Tobotimus requested a review from palmtree5 as a code owner July 15, 2019 08:42
mikeshardmind
mikeshardmind suggested changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause a regression. (We had tracebacks in support for cases not having the id) We need to fix the root cause. (the id missing from the stored dict)

mikeshardmind
mikeshardmind approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good here now.

@Tobotimus Tobotimus merged commit 778eadd into Cog-Creators:V3/develop Jul 15, 2019
@Tobotimus Tobotimus deleted the V3/bugfix/broken_modlog branch July 15, 2019 10:18
@Tobotimus Tobotimus mentioned this pull request Jul 15, 2019
Closed
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshardmind mikeshardmind mikeshardmind approved these changes

@palmtree5 palmtree5 Awaiting requested review from palmtree5

Assignees
No one assigned
Labels
High Priority High priority Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tobotimus @mikeshardmind @Jackenmen