Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Cog load fixes #2853

Closed
wants to merge 4 commits into from
Closed

[Core] Cog load fixes #2853

wants to merge 4 commits into from

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jul 12, 2019 •
edited
Loading

  • Fixes an issue observed on a live bot with a race condition with
    permissions

This includes a hack of a fix to get the best possible compromise
between an out of cycle breaking change, and a must fix issue fixed
ASAP

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

@mikeshardmind mikeshardmind added the High Priority High priority label Jul 12, 2019
@mikeshardmind mikeshardmind requested a review from Tobotimus July 12, 2019 22:10
@mikeshardmind mikeshardmind added this to the 3.1.3 milestone Jul 12, 2019
@mikeshardmind mikeshardmind added the Blocked By: Other PR Blocked by another PR. label Jul 13, 2019
@mikeshardmind
Copy link
Contributor Author

mikeshardmind commented Jul 13, 2019 •
edited
Loading

Due to a discussion in discord, the other discovered issues/fixes were split out into another PR. That should be merged either way. This can be merged afterward, but only if the other approaches being looked at are decided against.

Michael H added 3 commits July 12, 2019 21:59
address feedback
fb3e562
feedback
aa5bd8e
[Core] Cog load fixes
7db2080 
  - Fixes an issue observed on a live bot with a race condition with
  permissions
  - Fixes a potential issue spotted here during fix with permission
  hooks
  - Prevents accidentally overriding cogs (PR upstream to cog load?)

  This includes a hack of a fix to get the best possible compromise
  between an out of cycle breaking change, and a must fix issue fixed
  ASAP
@Tobotimus Tobotimus mentioned this pull request Jul 13, 2019
Merged
@mikeshardmind mikeshardmind removed this from the 3.1.3 milestone Jul 13, 2019
@mikeshardmind
Copy link
Contributor Author

closing in favor of #2857

@mikeshardmind mikeshardmind deleted the cog_load_fixes branch December 26, 2019 17:00
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Awaiting requested review from Tobotimus

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees
No one assigned
Labels
Blocked By: Other PR Blocked by another PR. High Priority High priority Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeshardmind @Jackenmen @Flame442