Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModLog] Prevent duplicate kwarg error #2848

Merged
merged 2 commits into from
Jul 13, 2019
Merged

[ModLog] Prevent duplicate kwarg error #2848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c094076
[ModLog] Prevent duplicate kwarg error
Tobotimus Jul 10, 2019
2668252
Don't mutate `data` argument
Tobotimus Jul 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion redbot/core/modlog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,9 @@ def from_json(cls, name: str, data: dict, **kwargs):
CaseType

"""
return cls(name=name, **data, **kwargs)
data_copy = data.copy()
data_copy.pop(name, None)
return cls(name=name, **data_copy, **kwargs)


async def get_next_case_number(guild: discord.Guild) -> int:
Expand Down