Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uvloop as Posix+CPython dependency and tweak new Make recipes #2819

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Add uvloop as Posix+CPython dependency and tweak new Make recipes #2819

merged 2 commits into from
Jul 2, 2019

Conversation

Tobotimus
Copy link
Member

@Tobotimus Tobotimus commented Jun 30, 2019 •
edited
Loading

These are the changes:

  • uvloop is a dependency on non-Windows CPython systems
  • make setupenv renamed to make newenv
  • make syncenv added to sync local venv to current dependencies
  • dev-requirements.txt moved into tools directory

@Tobotimus Tobotimus added the Type: Enhancement Something meant to enhance existing Red features. label Jun 30, 2019
@Tobotimus Tobotimus requested a review from Twentysix26 as a code owner June 30, 2019 05:25
@Tobotimus
Fix dev-requirements.txt path
3965d52 
Signed-off-by: Toby Harradine <[email protected]>
mikeshardmind
mikeshardmind approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

@Tobotimus Tobotimus merged commit 55e3091 into Cog-Creators:V3/develop Jul 2, 2019
@Tobotimus Tobotimus deleted the V3/uvloop_as_dep branch July 2, 2019 01:53
@mikeshardmind mikeshardmind added this to the 3.1.3 milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshardmind mikeshardmind mikeshardmind approved these changes

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees
No one assigned
Labels
Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobotimus @mikeshardmind