Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Update equalizer permissions #2813

Merged
merged 3 commits into from
Jul 14, 2019
Merged

[Audio] Update equalizer permissions #2813

merged 3 commits into from
Jul 14, 2019

Conversation

aikaterna
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Changed the equalizer permissions to be more in line with the rest of Audio's permission mechanics. The DJ role is now used to restrict access to the eq instead of using a mod/admin bot role or the administrator guild permission.

  • All users will be able to manage the eq if DJ role is off and there are no restrictions on subcommand use.
  • If the DJ role is on, and the user does not have the role, they will only be able to view the current eq.
  • Deleting eq presets now follows the same permissions style as playlist deletion. If the person is a bot mod/admin, bot owner, or other generally exempt user, they will be able to delete any eq setting. There is now an author field on eq settings, and if a pleb tries to delete someone else's setting they will not be able to.
  • If someone was using the dev version before these changes were made and they have saved eq settings, there are a few lines to handle that previous eq data storage file arrangement. Since there is no author, the mods/admins will need to be the ones to delete those settings as they will be the only user with authorization to do so.
  • The eq list command output has changed to show author and has a slightly different format.

@Tobotimus Tobotimus added Type: Enhancement Something meant to enhance existing Red features. and removed V3 labels Jun 29, 2019
Copy link
Member

@PredaaA PredaaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this PR, all changes that are listed in the description works as intended.

@NIXC
Copy link
Contributor

NIXC commented Jul 10, 2019

Had a look through as well, couldn't see anything out of the ordinary. Looks good to me.

Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just got one question for now :)

redbot/cogs/audio/audio.py Show resolved Hide resolved
@Tobotimus Tobotimus added this to the 3.1.3 milestone Jul 10, 2019
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'm happy with this then 👍

@mikeshardmind mikeshardmind merged commit be184b5 into Cog-Creators:V3/develop Jul 14, 2019
@aikaterna aikaterna deleted the patch-10 branch August 1, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants