Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken link in set color help message #2803

Merged
merged 3 commits into from
Jun 29, 2019
Merged

Fixed broken link in set color help message #2803

merged 3 commits into from
Jun 29, 2019

Conversation

lizzyd710
Copy link
Contributor

@lizzyd710 lizzyd710 commented Jun 25, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

In response to issue #2715
I fixed the broken link in /redbot/core/core_commands.py on line 853. Couldn't find a corresponding page with values on the Red documentation which would have been the ideal, but this is better than nothing.
EDIT: At the suggestion of @jack1142 the link now takes you to the discord.py v1.0.1 documentation for color converter.

Couldn't find a corresponding page with values on the Red documentation which would have been the ideal, but this is better than nothing.
@Jackenmen
Copy link
Member

Might be worth to link to v1.0.1 docs instead as that's what Red use

@Tobotimus Tobotimus added Type: Fix and removed V3 labels Jun 29, 2019
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided stable was best, as we're likely to forget to update this link every time we update the Discord version. Thanks for this PR though!

@Tobotimus Tobotimus merged commit 10412c4 into Cog-Creators:V3/develop Jun 29, 2019
@mikeshardmind mikeshardmind added this to the 3.1.3 milestone Jun 29, 2019
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants