Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Add equalizer #2787

Merged
merged 2 commits into from
Jun 24, 2019
Merged

[Audio] Add equalizer #2787

merged 2 commits into from
Jun 24, 2019

Conversation

aikaterna
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

An audio equalizer ([p]eq) has been added, thanks to Devoxin#0001's work on his own music player. I am usually reluctant to add commands that add more than roughly 5 emojis at once because of the time it takes applying and removing reactions and how that can lead to rate limiting on large bots that are very active, but this concern shouldn't apply to most of the users and it seemed one of the best options for user interface in regards to setting so many varied functions. For the folks that don't like interacting with reactions, there is also a command to use to set the bands directly instead.

  • 15 different bands can be adjusted in increments of 0.1, from -0.25 (completely removing the frequency) to 1.0 (0.25 is doubling it).
  • Bands to adjust include 25, 40, 63, 100, 160, 250, 400, 630, 1k, 1.6k, 2.5k, 4k, 6.3k, 10k, and 16k Hz.
  • [p]eq subcommands include: save to save the current eq, list to list saved eq settings, delete to remove a setting, load to load in a saved eq set, and set for setting bands directly
  • _clear_react has been modified to remove the bot's control reactions one by one when it lacks permissions to clear all reactions instead of leaving the reactions on the message.

@aikaterna aikaterna changed the title Patch 13 [Audio] Add equalizer Jun 22, 2019
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth modifying the eq set command to use the dict converter if people get tired of adding a band at a time for an easyish way to add multiple at once, but the initial work here is great, and that can be added on later.

@mikeshardmind mikeshardmind added this to the 3.1.3 milestone Jun 24, 2019
@mikeshardmind mikeshardmind merged commit f2b7ce9 into Cog-Creators:V3/develop Jun 24, 2019
@aikaterna aikaterna deleted the patch-13 branch June 25, 2019 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants