[Audio] Queue & misc cleanup #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeshardmind
previously approved these changes
Jun 24, 2019
mikeshardmind
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
[p]queue searchhas been split off into its own subcommand.The queue now has an information button in the same style as the equalizer to provide a prompt for queue group command help because the group commands for queue can be rather hidden if someone doesn't know they exist.
The now command has an increased timeout for reactions: 10s -> 30s due to user requests.
_attempt_connect 30 sec -> 50 sec. Most pi 3b+'s seem to take about 30-35 seconds to start, and some lower end devices take about 45 seconds. This change saves a few users from having to run the jar externally in another process.