[V3 Core] Add checks to [p]command #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeshardmind
suggested changes
Jun 13, 2019
There was a problem hiding this comment.
Checking if the person can run it shouldn't happen IMO. This removes the possiblity for the bot owner to manage enabled guild only commands from DMs. If the goal of this is to avoid a guild owner locking an owner command, check the requires object for the required permission level. Beyond that, there's no reason someone able to run a disable should be unable to disable commands.
|
Just pushed a commit to address the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Now makes sure that when running
[p]command disable, you are not disabling the[p]commandcommand. In addition, it makes sure the user running the[p]command <> servercommand can actually run the command they are disabling/enabling.