Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Audio] Improve Lavalink download/connection exception handling #2764

Merged
merged 6 commits into from
Jun 23, 2019
Merged

[Audio] Improve Lavalink download/connection exception handling #2764

merged 6 commits into from
Jun 23, 2019

Conversation

Tobotimus
Copy link
Member

@Tobotimus Tobotimus commented Jun 9, 2019 •
edited
Loading

  • More errors will be logged to the console with clearer messages when something goes wrong
  • Downloading the Lavalink Jar will abort after 5 failed attempts. The connect task will also abort if an unhandled exception occurs whilst downloading or connecting to Lavalink. After this occurs, instead of responding "Connection to Lavalink has not yet been established" to commands, the bot will respond "Connection to Lavalink has failed". This has no effect on other commands which don't involve connecting to Lavalink (e.g. settings commands).
  • Logs this message when Lavalink jar is successfully downloaded: Successfully downloaded Lavalink.jar (<x> bytes written)
  • Uses tqdm to display a progress bar whilst downloading Lavalink.jar.

@Tobotimus
[Audio] Improve Lavalink download/connection exception handling
502f6cb 
- More errors will be logged to the console with clearer messages when something goes wrong
- Downloading the Lavalink Jar will abort after 5 failed attempts. The connect task will also abort if an unhandled exception occurs whilst downloading or connecting to Lavalink. After this occurs, instead of responding "Connection to Lavalink has not yet been established" to commands, the bot will respond "Connection to Lavalink has failed". This has no effect on other commands which don't involve connecting to Lavalink (e.g. settings commands)

Signed-off-by: Toby Harradine <[email protected]>
@Tobotimus Tobotimus added Type: Enhancement Something meant to enhance existing Red features. QA: Needed labels Jun 9, 2019
@Tobotimus Tobotimus requested a review from aikaterna June 9, 2019 04:04
@Tobotimus Tobotimus mentioned this pull request Jun 9, 2019
Closed
@Tobotimus Tobotimus requested a review from Twentysix26 as a code owner June 9, 2019 06:43
aikaterna
aikaterna previously approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@aikaterna aikaterna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after the conflicts are resolved.

@Tobotimus Tobotimus added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Needed labels Jun 23, 2019
@Tobotimus Tobotimus merged commit 1804314 into Cog-Creators:V3/develop Jun 23, 2019
@Tobotimus Tobotimus deleted the V3/log_lavalink_download_errors branch June 23, 2019 04:10
@mikeshardmind mikeshardmind added this to the 3.1.3 milestone Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aikaterna aikaterna aikaterna left review comments

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees

@aikaterna aikaterna

Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Tobotimus @aikaterna @mikeshardmind