Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Pass exceptions on Cog Load to user. #2754

Merged
merged 1 commit into from
Jun 2, 2019
Merged

[Core] Pass exceptions on Cog Load to user. #2754

merged 1 commit into from
Jun 2, 2019

Conversation

Bakersbakebread
Copy link
Contributor

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Passed exception to fix #2752

mikeshardmind
mikeshardmind approved these changes Jun 2, 2019
View reviewed changes
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes it in a sufficient enough way for now. I want to take a closer look at some of how we're handling this later, but for now, this should be fine.

@mikeshardmind mikeshardmind added this to the 3.1.3 milestone Jun 2, 2019
@mikeshardmind mikeshardmind merged commit 9116cd0 into Cog-Creators:V3/develop Jun 2, 2019
@mikeshardmind mikeshardmind changed the title [2752] Pass exception through [Core] Pass exceptions on Cog Load to user. Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshardmind mikeshardmind mikeshardmind approved these changes

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.

[3.1.2][Core] Conflicting commands empty error message
2 participants
@Bakersbakebread @mikeshardmind