Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Improve automated checks #2702

Merged
merged 10 commits into from
Jun 2, 2019
Merged

[CI] Improve automated checks #2702

merged 10 commits into from
Jun 2, 2019

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented May 18, 2019 •
edited
Loading

This immediately caught several things we have open PRs for, as well as
some which we do not.

  • This leverages pylint
  • This includes a .pylintrc with some very specific things already
    disabled, including entire categories in a few cases
  • closes [Tests] Tests aren't catching missing imports. #2644
  • This adds a few specific exceptions where known spurious
  • This includes a few small changes to remove minor issues

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This should reduce the chances of uncaught issues. This can't be merged prior to specific things being fixed. (see: #2699 , #2676 , #2686 )

@mikeshardmind mikeshardmind added Type: Enhancement Something meant to enhance existing Red features. V3 labels May 18, 2019
@mikeshardmind mikeshardmind requested a review from palmtree5 as a code owner May 18, 2019 09:17
@mikeshardmind
Copy link
Contributor Author

This is ready to go, but blocked by an error newly caught by the new CI config to be fixed in #2688

@mikeshardmind mikeshardmind added this to the 3.1.2 milestone May 23, 2019
@mikeshardmind mikeshardmind modified the milestones: 3.1.2, 3.1.3 May 31, 2019
@mikeshardmind mikeshardmind requested a review from Kowlin June 1, 2019 18:09
@Kowlin Kowlin merged commit 16443c8 into Cog-Creators:V3/develop Jun 2, 2019
@mikeshardmind mikeshardmind deleted the use-pylint branch December 26, 2019 16:59
@Jackenmen Jackenmen added Category: Meta This is related to the repository maintenance. Category: CI This is related to repository's CI configuration. and removed Category: Tests labels Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kowlin Kowlin Kowlin approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

@palmtree5 palmtree5 Awaiting requested review from palmtree5 palmtree5 is a code owner

Assignees
No one assigned
Labels
Category: CI This is related to repository's CI configuration. Category: Meta This is related to the repository maintenance. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.

[Tests] Tests aren't catching missing imports.
3 participants
@mikeshardmind @Kowlin @Jackenmen