[V3 common filters/context/modlog] Update for spoilers #2401
+66
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2019 22:56
Spoilers are not handled in usernames and other untrustable user content. This is technically a breaking change if anyone is already having their bot send spoilered content, but includes documentation on getting the previous behavior instead.
Tobotimus
added
Type: Enhancement
Signed-off-by: Toby Harradine <[email protected]>
Tobotimus
approved these changes
Feb 16, 2019
Tobotimus
added
QA: Passed
Tobotimus
pushed a commit
that referenced
this pull request
Feb 16, 2019
This also wraps some fields of the modlog with the same sanitization, as well as the `[p]names` command.
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spoilers are not handled in usernames and other untrustable user content.
This also wraps some fields of the modlog with the same sanitization.
Type
Description of the changes
No longer done as a breaking change per discussion in discord.