[Mod] Fixed not handling of nicknames that are too long. #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeshardmind
suggested changes
Dec 2, 2018
There was a problem hiding this comment.
This still isn't completely sufficient for preventig a traceback with this. see https://discordapp.com/developers/docs/resources/user#usernames-and-nicknames, should wrap in a try/except additionally.
mikeshardmind
suggested changes
Dec 14, 2018
| await user.edit(reason=get_audit_reason(ctx.author, None), nick=nickname) | ||
| try: | ||
| await user.edit(reason=get_audit_reason(ctx.author, None), nick=nickname) | ||
| except discord.Forbidden: |
There was a problem hiding this comment.
I'd prefer doing a hierarchy and perm check before the API call here.
The other error still needs to be caught for cases where the nick limitation is a result of discord not sharing all invalid nick parameters.
Signed-off-by: Toby Harradine <[email protected]>
Tobotimus
approved these changes
Dec 16, 2018
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Fixed Mod not handling nicknames that exceed 32 characters.