Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3 Utils] Markdown helpers escape special chars #2182

Merged
merged 1 commit into from
Oct 6, 2018
Merged

[V3 Utils] Markdown helpers escape special chars #2182

merged 1 commit into from
Oct 6, 2018

Conversation

Twentysix26
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Implements #1841
From my tests escaping italics (*) that get passed to italics() doesn't work, the string still won't show up properly. If you can think of a way let me know.

@Twentysix26 Twentysix26 requested a review from tekulvw as a code owner October 4, 2018 22:03
@Twentysix26 Twentysix26 added Type: Enhancement Something meant to enhance existing Red features. V3 labels Oct 4, 2018
Tobotimus
Tobotimus approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I can't think of a way to escape italics right now, and unfortunately we know code-blocks can't be escaped properly, but this will do for now 😃

@Tobotimus Tobotimus added the QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). label Oct 6, 2018
@Tobotimus Tobotimus self-assigned this Oct 6, 2018
@Tobotimus Tobotimus added this to the RC 1 milestone Oct 6, 2018
@Tobotimus Tobotimus merged commit 03892f5 into V3/develop Oct 6, 2018
@Tobotimus Tobotimus mentioned this pull request Oct 6, 2018
Closed
@Tobotimus Tobotimus deleted the V3/enhanced-helpers branch October 6, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

Assignees

@Tobotimus Tobotimus

Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.0.0rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@Twentysix26 @Tobotimus