Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3 Config] Add Group.clear_raw method #2178

Merged
merged 2 commits into from
Oct 5, 2018
Merged

[V3 Config] Add Group.clear_raw method #2178

merged 2 commits into from
Oct 5, 2018

Conversation

Zephyrkul
Copy link
Contributor

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Adds a clear_raw method to Group objects, similar to the existing get_raw and set_raw methods.
Documentation included.

@Tobotimus
Copy link
Member

Thanks, could you add a test?

@Tobotimus Tobotimus added V3 QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. Type: Feature New feature or request. labels Oct 4, 2018
@Tobotimus Tobotimus self-assigned this Oct 4, 2018
@Tobotimus Tobotimus modified the milestone: RC 1 Oct 4, 2018
@Zephyrkul Zephyrkul requested a review from Twentysix26 as a code owner October 4, 2018 00:36
@Zephyrkul
Copy link
Contributor Author

Test added. I've never done pytests before but I think I did it right.

@Tobotimus Tobotimus added QA: Needed and removed QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. labels Oct 5, 2018
Tobotimus
Tobotimus approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 😃

@Tobotimus Tobotimus added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Needed labels Oct 5, 2018
@Tobotimus Tobotimus added this to the RC 1 milestone Oct 5, 2018
@Tobotimus Tobotimus merged commit ebc657d into Cog-Creators:V3/develop Oct 5, 2018
@Zephyrkul Zephyrkul deleted the V3/config-clear-raw branch October 5, 2018 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

@palmtree5 palmtree5 Awaiting requested review from palmtree5

@tekulvw tekulvw Awaiting requested review from tekulvw

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees

@Tobotimus Tobotimus

Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Feature New feature or request.
Projects
None yet
Milestone
3.0.0rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@Zephyrkul @Tobotimus