Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3 Core Events] Check module existence in should_log_sentry #2139

Merged
merged 1 commit into from
Sep 23, 2018
Merged

[V3 Core Events] Check module existence in should_log_sentry #2139

merged 1 commit into from
Sep 23, 2018

Conversation

Zephyrkul
Copy link
Contributor

Type

  • Bugfix

Description of the changes

Allows for a lack of module (which returns False) for should_log_sentry. This allows for, say, commands to be added by the Dev cog. ( ͡ಠ ʖ̯ ͡ಠ)

@Zephyrkul Zephyrkul requested a review from tekulvw as a code owner September 20, 2018 02:57
@Kowlin Kowlin added V3 labels Sep 20, 2018
@Tobotimus Tobotimus added QA: Bypassed QA is unnecessary. and removed QA: Unassigned labels Sep 23, 2018
@Tobotimus Tobotimus merged commit a3c36d4 into Cog-Creators:V3/develop Sep 23, 2018
@Zephyrkul Zephyrkul deleted the patch-1 branch October 3, 2018 02:09
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

Assignees
No one assigned
Labels
QA: Bypassed QA is unnecessary. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zephyrkul @Tobotimus @Jackenmen @Kowlin